#14:optimize memtable switch latency #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayulas
approved these changes
Jun 27, 2022
ayulas
force-pushed
the
14-import-shorten-memtable-switch-latency
branch
from
c1f3064 to
d9915cd
Compare
Closed
With the new speedb memtable, each memtable switch needs to wait for the allocation and initialization of ~8MiB, which creates spikes in latency when switching memtables. Add a thread per CF to allocate new memtables in the background so that they'll be ready to be used when a switch happens. In case memtable is not ready when switch occor the memtable will be created immediately pending memtable shouldnt be calculate as used
ayulas
force-pushed
the
14-import-shorten-memtable-switch-latency
branch
from
d9915cd to
7115af7
Compare
This was referenced Jul 25, 2022
Merged
isaac-io
added a commit
that referenced
this pull request
Jul 27, 2022
isaac-io
added a commit
that referenced
this pull request
Jul 27, 2022
isaac-io
added a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new speedb memtable, each memtable switch needs to wait
for the allocation and initialization of ~8MiB, which creates
spikes in latency when switching memtables. Add a thread per CF
to allocate new memtables in the background so that they'll be
ready to be used when a switch happens.
Closes #14