unit tests: fix db_test PurgeInfoLogs by creating unique db path (#273) #324
Conversation
create a unique db path for each new db opened in a suite. the PerThreadDBPath creates a db path based on the PID and the thread so that every test in the suite (e.g. db_test) has the exact same db path. this leads to unwanted leftovers which caused an error in PurgeInfoLogs.
|
currently checking if it hasnt broken any existing unit tests - https://github.com/speedb-io/speedb/actions/runs/3824428690 |
|
both CI running the units tests and running the unit tests serially (J=1) on an azure instance finished successfully. |
|
Another solution was introduced in facebook/rocksdb#10000, but never merged. This solution allows tests to be tracked back to their test name, making it easier to find the data associated with a test. |
|
looks great, by name is definitely better. why was it not merged? |
Not sure why it was never merged. There was no discussion outside of the public comments. Feel free to merge it (or I can later in the week). |
Yuval-Ariel
requested review from
mrambacher
and removed request for
udi-speedb
|
we've decided that @mrambacher will port the PR mentioned which does the same fix but with test name instead of a timestamp. |
create a unique db path for each new db opened in a suite. the PerThreadDBPath creates a db path based on the PID and the thread so that every test in the suite (e.g. db_test) has the exact same db path. this leads to unwanted leftovers which caused an error in PurgeInfoLogs.