32 general bug fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we decide to include SPDB-197 even though the Java side is still broken? |
there was no decision to exclude it. i dont mind either way |
|
Let's drop the enforcement part, reword the commit message, and open an issue to track this (both exposing it on the Java side as well as the enforcement part). |
isaac-io
force-pushed
the
32-general-bug-fixes
branch
from
fd57734 to
05ae45a
Compare
|
Due to facebook/rocksdb#10256, SPDB-197, SPDB-243, and SPDB-381 cannot be integrated. Let's drop them for now and discuss what to do about them. |
Yuval-Ariel
force-pushed
the
32-general-bug-fixes
branch
from
05ae45a to
0fa690e
Compare
Yuval-Ariel
assigned assaf-speedb and Yuval-Ariel and unassigned Yuval-Ariel and assaf-speedb
Yuval-Ariel
force-pushed
the
32-general-bug-fixes
branch
2 times, most recently
from
2f9dfaf to
0b116ea
Compare
|
removed SPDB-571 which should be included in SPDB-702-avoid-unnecessary-blocking-io since it solves a bug revealed by that setting. |
Yuval-Ariel
force-pushed
the
32-general-bug-fixes
branch
from
5b92e94 to
36a8ce5
Compare
…s status code This breaks when comparing against e.g. `Status::NoSpace()` because it has a status code of `Code::kIOError` and only a subcode of `SubCode::kNoSpace`.
…status code This breaks in cases such as `Status::NoSpace()`, which has a status code of `Code::kIOError`, and a subcode of `SubCode::kNoSpace`, but the comparison ends up checking only if a general IO error happened.
The example acquires snapshots but doesn't release them, resulting in a memory leak error when run under ASan.
test doesnt delete db properly.
fix both these tests to operate not only on the default cf
isaac-io
force-pushed
the
32-general-bug-fixes
branch
from
36a8ce5 to
4e5dae3
Compare
isaac-io
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32