unit tests: fix CompactionServiceTest.RemoteEventListener (#314) #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test assumes that each compaction job_id from the remote compaction is unique but in fact all the job_ids are 1. the test passed thus far since there was just 1 bg compaction by default. once we increased it to 8, there could be concurrent remote compactions which led to this error.
ayulas
reviewed
Jan 8, 2023
ayulas
approved these changes
Jan 8, 2023
Yuval-Ariel
deleted the
314-unit-tests-enable-compactionservicetestremoteeventlistener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test assumes that each compaction job_id from the remote compaction is unique but in fact all the job_ids are 1.
the test passed thus far since there was just 1 bg compaction by default. once we increased it to 8, there could be concurrent remote compactions which led to this error.