dont use AVX512 with asan #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
force-pushed
the
284-stress-test-error-segv-from-xxh3
branch
from
555114f to
666d92f
Compare
|
the problem doesnt reproduce with this branch |
|
@Yuval-Ariel Please add a comment explaining why you avoid using AVX512 when MUST_FREE_HEAP_ALLOCATIONS (== ASAN). |
Yuval-Ariel
force-pushed
the
284-stress-test-error-segv-from-xxh3
branch
from
666d92f to
e9f809e
Compare
right you are, done |
udi-speedb
approved these changes
Feb 13, 2023
|
Do we understand why this happens on the Speedb code and is not seen in Rocks? Is it a different test suite or something different? |
Unless I am mistaken, it does happen in RocksDB as well. This is a workaround that would let us test with ASAN. We should open an issue for RocksDB. |
|
yes, @udi-speedb is correct. |
ayulas
pushed a commit
that referenced
this pull request
Feb 26, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
Yuval-Ariel
added a commit
that referenced
this pull request
May 1, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
Yuval-Ariel
added a commit
that referenced
this pull request
May 3, 2023
the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
Yuval-Ariel
added a commit
that referenced
this pull request
May 4, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
Yuval-Ariel
added a commit
that referenced
this pull request
May 11, 2023
the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
Yuval-Ariel
added a commit
that referenced
this pull request
May 11, 2023
fix - AXV512: don't use XXH3_accumulate_512 with ASAN (#398) the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
udi-speedb
pushed a commit
that referenced
this pull request
Nov 13, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
udi-speedb
pushed a commit
that referenced
this pull request
Nov 15, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
udi-speedb
pushed a commit
that referenced
this pull request
Nov 19, 2023
fix - AXV512: don't use XXH3_accumulate_512 with ASAN (#398) the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 4, 2023
avoid these functions when running with ASAN since they caused errors in the stress test. this happens in rocksdb as well and this is only meant as a workaround to continue ASAN testing.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
fix - AXV512: don't use XXH3_accumulate_512 with ASAN (#398) the previous commit disabled all the rest of the XXH optimizations since it didnt prevent the XXH_VECTOR from being defined as XXH_AVX512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.