Stress error utf 8 codec cant decode byte #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
added
Upstreamable
udi-speedb
previously approved these changes
May 8, 2023
|
@Yuval-Ariel - Please just verify that no other call to this function suffers from the same problem. |
|
done. i'll merge it to main once the rebase is over. |
Yuval-Ariel
force-pushed
the
8-1-1-rebase-main-candidate
branch
from
3349f79 to
2ffee5b
Compare
Yuval-Ariel
force-pushed
the
stress-error-utf-8-codec-cant-decode-byte
branch
from
407f6c1 to
b3db7cd
Compare
|
@udi-speedb plz reapprove. i've rebased on current main |
udi-speedb
approved these changes
May 11, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 19, 2023
when verify_before_write = true, msg_prefix was misplaced and the value from the db was inserted instead of it which led to junk and a decoding error.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
when verify_before_write = true, msg_prefix was misplaced and the value from the db was inserted instead of it which led to junk and a decoding error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #496