Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC: fix for stop while shutting down #499

Merged
merged 3 commits into from
May 24, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update GetDelay comment
Yuval-Ariel committed May 24, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 719b4ea09504b63e800adedba25e02e82b601327
2 changes: 1 addition & 1 deletion db/write_controller.cc
Original file line number Diff line number Diff line change
@@ -128,7 +128,7 @@ bool WriteController::IsStopped() const {
return total_stopped_.load(std::memory_order_relaxed) > 0;
}

// This is inside DB mutex, so we can't sleep and need to minimize
// This is inside the calling DB mutex, so we can't sleep and need to minimize
// frequency to get time.
// If it turns out to be a performance issue, we can redesign the thread
// synchronization model here.