Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the DropWrites Test #544

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Re-enable the DropWrites Test #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2142097
Fix Test
mrambacher Jun 8, 2023
2fac03b
Merge remote-tracking branch 'upstream/main' into DropWritesTest
mrambacher Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions db/db_io_failure_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class DBIOFailureTest : public DBTestBase {
};

// Check that number of files does not grow when writes are dropped
TEST_F(DBIOFailureTest, DISABLED_DropWrites) {
TEST_F(DBIOFailureTest, DropWrites) {
do {
Options options = CurrentOptions();
options.env = env_;
Expand All @@ -30,7 +30,7 @@ TEST_F(DBIOFailureTest, DISABLED_DropWrites) {
ASSERT_OK(Put("foo", "v1"));
ASSERT_EQ("v1", Get("foo"));
Compact("a", "z");
const size_t num_files = CountFiles();
const auto num_files = GetSstFileCount(dbname_);
// Force out-of-space errors
env_->drop_writes_.store(true, std::memory_order_release);
env_->sleep_counter_.Reset();
Expand Down Expand Up @@ -59,7 +59,7 @@ TEST_F(DBIOFailureTest, DISABLED_DropWrites) {
ASSERT_EQ("5", property_value);

env_->drop_writes_.store(false, std::memory_order_release);
const size_t count = CountFiles();
const auto count = GetSstFileCount(dbname_);
ASSERT_LT(count, num_files + 3);

// Check that compaction attempts slept after errors
Expand Down