Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

560: Tombstone test fixes as a result of not clear local variable #561

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ayulas
Copy link
Contributor

@ayulas ayulas commented Jun 13, 2023

No description provided.

@ayulas ayulas requested a review from Yuval-Ariel June 13, 2023 16:21
@ayulas
Copy link
Contributor Author

ayulas commented Jun 13, 2023

@yuval pls review . for some reason the unit test passed on the CI but not on the mac. now it is passed on the mac as well
it must inserted to the version... no need performance test to it

@ayulas ayulas force-pushed the 560-tombsobne-test-failure branch from 4442950 to 7638c2d Compare June 13, 2023 16:25
Copy link
Contributor

@Yuval-Ariel Yuval-Ariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayulas
Copy link
Contributor Author

ayulas commented Jun 13, 2023

toda!!!

@Yuval-Ariel Yuval-Ariel linked an issue Jun 13, 2023 that may be closed by this pull request
@Yuval-Ariel Yuval-Ariel merged commit 201de3d into main Jun 14, 2023
@Yuval-Ariel Yuval-Ariel deleted the 560-tombsobne-test-failure branch June 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge issue with Tombstone.. cause failed test on Mac
2 participants