unit tests: Fix GlobalAndWBMSetupDelay #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that calling Flush with FlushOptions.wait = true, doesn't wait for the memory to be free which also happens during the flush process. So the fix is adding a sync point which delays the assertion of checking the WBM memory usage to after the flush cleared the memtable memory.
udi-speedb
pushed a commit
that referenced
this pull request
Nov 22, 2023
The problem was that calling Flush with FlushOptions.wait = true, doesn't wait for the memory to be freed which also happens during the flush process. So the fix is adding a sync point which delays the assertion of checking the WBM memory usage to after the flush cleared the memtable memory.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
The problem was that calling Flush with FlushOptions.wait = true, doesn't wait for the memory to be freed which also happens during the flush process. So the fix is adding a sync point which delays the assertion of checking the WBM memory usage to after the flush cleared the memtable memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUN ] GlobalWriteControllerTest.GlobalAndWBMSetupDelay
db/global_write_controller_test.cc:391: Failure
Value of: options.write_buffer_manager->memory_usage() < 5_kb
Actual: false
Expected: true
FAILED ] [GlobalWriteControllerTest.GlobalAndWBMSetupDelay (44 ms)
The memory is freed only when the detor of the version is called in
job_context.Clean();underDBImpl::BackgroundCallFlush.The problem was that calling Flush with
FlushOptions.wait = true, doesn't wait for the memory to be free which also happens during the flush process.So the fix is adding a sync point which delays the assertion of checking the WBM memory usage to after the flush cleared the memtable memory.