unit tests: fix DisableMultiManualCompaction in db_compaction_test #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test sometimes failed in CI since the test code assumed there was only 1 bg compaction thread which needed to be blocked but in #194, the default was changed to 8 so the fix is simply to block all the bg threads.
RoyBenMoshe
approved these changes
Jul 27, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 22, 2023
) The test sometimes failed in CI since the test code assumed there was only 1 bg compaction thread which needed to be blocked but in #194, the default was changed to 8 so the fix is simply to block all the bg threads.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
) The test sometimes failed in CI since the test code assumed there was only 1 bg compaction thread which needed to be blocked but in #194, the default was changed to 8 so the fix is simply to block all the bg threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #580 .
The test sometimes failed in CI since the test code assumed there was only 1 bg compaction thread which needed to be blocked but in #194, the default was changed to 8 so the fix is simply to block all the bg threads.