653: Support hash spdb as part of enable speedb features #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayulas
force-pushed
the
653-remove-hashspdb-deprecate-us_seek_parallel-param
branch
from
1cbcf2c to
dd36798
Compare
RoyBenMoshe
approved these changes
Aug 29, 2023
mrambacher
reviewed
Aug 31, 2023
Comment on lines
-555
to
-558
| {"use_seek_parallel_threshold", | ||
| {offsetof(struct HashSpdbRepOptions, use_seek_parallel_threshold), | ||
| OptionType::kBoolean, OptionVerificationType::kNormal, | ||
| OptionTypeFlags::kNone}}, |
There was a problem hiding this comment.
If anyone has an Options file with this written to it, removing this will break backwards compatibility. The standard practice is to set the offset to 0 and use the deprecated flag. This way options files which have this value will continue to work but the value will be ignored.
|
whats the status here? |
Yuval-Ariel
force-pushed
the
653-remove-hashspdb-deprecate-us_seek_parallel-param
branch
from
dd36798 to
a129581
Compare
Yuval-Ariel
approved these changes
Oct 17, 2023
ayulas
force-pushed
the
653-remove-hashspdb-deprecate-us_seek_parallel-param
branch
3 times, most recently
from
fe20d01 to
e45c941
Compare
ayulas
changed the title
ayulas
force-pushed
the
653-remove-hashspdb-deprecate-us_seek_parallel-param
branch
from
e45c941 to
e22fb5f
Compare
udi-speedb
pushed a commit
that referenced
this pull request
Nov 23, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 30, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.