Fix some build issues #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrambacher
commented
Sep 5, 2023
mrambacher
commented
- Fix the tests so that the pass (as well as they do for RocksDB) when ASSERT_STATUS_CHECKED is defined;
- Fix the "set by unused" variable warning in db_bench on MacOS
1. Fix the tests so that the pass (as well as they do for RocksDB) when ASSERT_STATUS_CHECKED is defined; 2. Fix the "set by unused" variable warning in db_bench on MacOS
|
@Yuval-Ariel Please merge |
|
it seems the ci is failing.. |
|
@mrambacher can you please check why the CI is failing. rebase on main first |
Yuval-Ariel
added a commit
that referenced
this pull request
Oct 15, 2023
This reverts commit 877f2a5.
udi-speedb
pushed a commit
that referenced
this pull request
Nov 23, 2023
1. Fix the tests so that the pass (as well as they do for RocksDB) when ASSERT_STATUS_CHECKED is defined; 2. Fix the "set by unused" variable warning in db_bench on MacOS
udi-speedb
pushed a commit
that referenced
this pull request
Dec 6, 2023
1. Fix the tests so that the pass (as well as they do for RocksDB) when ASSERT_STATUS_CHECKED is defined; 2. Fix the "set by unused" variable warning in db_bench on MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.