Report static pinning options to the log (#691) #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udi-speedb
requested review from
Yuval-Ariel and
ofriedma
and removed request for
Yuval-Ariel
udi-speedb
force-pushed
the
691-static-pinning-report-the-policy-type-and-applicable-parameters-to-the-log
branch
from
18bbdb3 to
3afab35
Compare
udi-speedb
force-pushed
the
691-static-pinning-report-the-policy-type-and-applicable-parameters-to-the-log
branch
from
3afab35 to
2d858a9
Compare
udi-speedb
requested review from
Yuval-Ariel
and removed request for
ofriedma
Yuval-Ariel
approved these changes
Oct 12, 2023
| @@ -16,8 +16,12 @@ | |||
|
|
|||
| #include "plugin/speedb/pinning_policy/scoped_pinning_policy.h" | |||
|
|
|||
| #include <inttypes.h> | |||
|
|
|||
There was a problem hiding this comment.
@Yuval-Ariel - The space line was actually inserted by the make format (it just failed due to that), so, I am leaving it as is.
HISTORY.md
Outdated
| @@ -9,6 +9,7 @@ Fix RepeatableThread to work properly with on thread start callback feature (htt | |||
|
|
|||
| ### Enhancements | |||
| * Unit Testing: Expose the disallow_trivial_move flag in the MoveFilesToLevel testing utility (#677). | |||
| * Static Pinning: Report pinning policy name and paramteres to the log (#691). | |||
udi-speedb
force-pushed
the
691-static-pinning-report-the-policy-type-and-applicable-parameters-to-the-log
branch
from
64f1bf9 to
96c4fa0
Compare
…port-the-policy-type-and-applicable-parameters-to-the-log
Yuval-Ariel
approved these changes
Oct 12, 2023
udi-speedb
deleted the
691-static-pinning-report-the-policy-type-and-applicable-parameters-to-the-log
branch
Yuval-Ariel
pushed a commit
that referenced
this pull request
Oct 12, 2023
udi-speedb
added a commit
that referenced
this pull request
Nov 23, 2023
udi-speedb
added a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.