pending memtable should be updated with the current mutable cf option…

[ayulas]

pending memtable should be updated with the current mutable cf options during activation

[isaac-io]

Only now realising that the activation mechanism is not working correctly. We cannot change arena parameters after memtable rep construction (because the memtable rep constructor may use the arena to allocate memory). Memtable rep construction happens in the MemTable constructor member initialisation list, regardless of activation.

[ayulas]

Only now realising that the activation mechanism is not working correctly. We cannot change arena parameters after memtable rep construction (because the memtable rep constructor may use the arena to allocate memory). Memtable rep construction happens in the MemTable constructor member initialisation list, regardless of activation.

this what i wrote. that the arena on all the memtable rep is used only for memtable ios and what the insert incolve with (iterator etc) in the constructor it is not used. not for bucket and not for other things

[ayulas]

Only now realising that the activation mechanism is not working correctly. We cannot change arena parameters after memtable rep construction (because the memtable rep constructor may use the arena to allocate memory). Memtable rep construction happens in the MemTable constructor member initialisation list, regardless of activation.

this what i wrote. that the arena on all the memtable rep is used only for memtable ios and what the insert incolve with (iterator etc) in the constructor it is not used. not for bucket and not for other things

done what we agreed

[isaac-io]

Unfortunately I missed another place where memory is allocated from the arena on memtable construction: the range_del_table_ member of MemTable is always created with a skiplist memtable :(

We might need to instead create a pool of actual memtables representations (not the MemTable type) and pull from there on memtable switch.