Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsEmpty() checks were missing before some SwitchMemtable() invocation… #808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

IsEmpty() checks were missing before some SwitchMemtable() invocation… #808

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13f0034
IsEmpty() checks were missing before some SwitchMemtable() invocation…
Jan 13, 2024
002c48c
test
Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion db/db_impl/db_impl_write.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,7 +2140,10 @@ Status DBImpl::SwitchMemtable(ColumnFamilyData* cfd, WriteContext* context) {
log::Writer* new_log = nullptr;
MemTable* new_mem = nullptr;
IOStatus io_s;


if(cfd->mem()->IsEmpty()) {
return Status::OK();
}
// Recoverable state is persisted in WAL. After memtable switch, WAL might
// be deleted, so we write the state to memtable to be persisted as well.
Status s = WriteRecoverableState();
Expand Down
Loading