Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a fixture and broken test for module.exports #25

Merged

Conversation

elicwhite
Copy link
Contributor

Adding a test case, fixture, and first step to fixing the module.exports non-enumerable transformation.

I noticed you had these expectation files in a specific folder. Matching the file structure and building off of the previous PR to try to fix it.

There are failing tests that probably need to be updated now that I changed this one but have to run out. I figure this is a good starting point and I will continue playing around with it if you don't get to it right away.

@speedskater
Copy link
Owner

Thanks for your PR. I integrated it into the branch transform-test-module-exports.
Could you please add usage samples for common.js module.exports where you test the rewire properties are indeed exported as non-enumerable properties?

@elicwhite
Copy link
Contributor Author

Is there anything left for this?

@speedskater
Copy link
Owner

Thanks for providing this PR. I think this should be enough. As it seems that the latest changes have caused some regressions (#28) I will fix them first before i merge your PR. I think it will take till tomorrow. Sorry again for the delay.

@speedskater speedskater merged commit 12fbfc0 into speedskater:master Aug 7, 2015
@elicwhite elicwhite deleted the transform-test-module-exports branch August 7, 2015 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants