Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue parsing methods with char args #27

Merged

Conversation

Siphonophora
Copy link
Contributor

Existing string parsing didn't handle special characters in chars, per https://github.com/spekt/nunit.testlogger/issues/90

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #27 (60b75d4) into master (f710cec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          536       552   +16     
=========================================
+ Hits           536       552   +16     
Impacted Files Coverage Δ
src/TestLogger/Core/TestCaseNameParser.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f710cec...60b75d4. Read the comment docs.

@Siphonophora
Copy link
Contributor Author

@codito Apparently I can't assign you, please take a look at this.

@codito codito merged commit b5078d1 into spekt:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants