Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include [Theory] data in xUnit test names #29

Closed
wants to merge 1 commit into from

Conversation

hach-que
Copy link

@hach-que hach-que commented Dec 26, 2021

This fixes spekt/junit.testlogger#50 by including the xUnit theory data in test names.

@hach-que hach-que changed the title Include [Theory] parameters in test names Include [Theory] data in xUnit test names Dec 26, 2021
This fixes spekt/junit.testlogger#50 by including the xUnit theory data in test names.
@@ -46,6 +46,14 @@ public class XunitTestAdapter : ITestAdapter
result.Messages.Add(new TestResultMessage("skipReason", skipReason));
}

string displayName = result.Result.DisplayName;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing because of the trailing whitespace here.

Siphonophora added a commit to Siphonophora/testlogger that referenced this pull request Feb 27, 2022
Co-Authored-By: June Rhodes <jrhodes@redpoint.games>
@Siphonophora
Copy link
Contributor

Siphonophora commented Mar 5, 2022

@hach-que we will close this in favor of #30 which I pulled your commit into.

@codito Can you close this?

@codito
Copy link
Contributor

codito commented Mar 11, 2022

Closing since this is already part of #30

@codito codito closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Member data not included in output name
4 participants