Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrap options in label for th2 export #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

speleo3
Copy link
Owner

@speleo3 speleo3 commented Mar 2, 2025

Add support for scrap options in the layer label. These options have the highest priority and overwrite global options (command line --scale, --projection, --options). They also overwrite options from the therion:options attribute, if present.

options-prio

Breaking changes:

  • therion:options now overwrites command line --options
  • New default for --scale is undefined, previous value was 100
  • Scrap name ends at first - (space, dash)

@AHspeleo FYI

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.21%. Comparing base (cae9256) to head (3601fd5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   74.14%   74.21%   +0.07%     
==========================================
  Files          13       13              
  Lines        4080     4084       +4     
==========================================
+ Hits         3025     3031       +6     
+ Misses       1055     1053       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants