-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP enable user to specify .tar output or not and warn about incompatibilities w/ old tar version #160
Conversation
@spencerahill this looks very good. Thanks for adding docstrings to |
@spencerkclark perfect, thanks! Will wrap up the rest of this by the end of the night. |
The
|
Also changed _compute_or_skip_on_error to skip on any exception, rather than just RuntimeError. I think this is better for the user, and it makes testing it easier by making it easy to generate an exception that this line will catch. In order to test the logging, I am using the pytest-catchlog plugin, which is one of pytest's official plugins. I have added it to the CI files and to setup.py; it's possible that further tinkering will be required to get it to work with the CI.
Fully agree, thanks for making this change!
Really nice find on this. It's great to be able to have the logging tested too. If you're satisfied I think this is ready for a what's new and then a merge. |
@spencerkclark thanks! A little more in the way of docs + what's new, then will merge.
I agree, I have been wanting to figure this out for a while. Of course, getting it to work made me realize all the ways we could be doing logging better! Will try to gather my thoughts on that in an Issue sometime. |
I am actually going to include the warning in the docs with the PR for #150...I have a local git stash where I had started in on that, and it will be easier to add this doc update along with that. |
Closes #157
This first commit gets the functionality in place, namely that users can specify
write_to_tar
as a member of the newly createdcalc_exec_options
dict that gets passed tosubmit_mult_calcs
along with the other options that had been already being passed tosubmit_mult_calcs
.Tests and docs (including the warning about the old tar version on Macs) still needed, but @spencerkclark wanted to share this now in case you have any suggestions on the overall approach.
(Tied up for next couple hours but will return to this later today.)