-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery Starbot ⭐ refactored spencerahill/aospy #335
base: master
Are you sure you want to change the base?
Conversation
# filter out many common branch names like "release" and | ||
# "stabilization", as well as "HEAD" and "master". | ||
tags = set([r for r in refs if re.search(r'\d', r)]) | ||
# a heuristic: assume all version tags have a digit. The old git %d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
E501 line too long (83 > 79 characters)
# "stabilization", as well as "HEAD" and "master". | ||
tags = set([r for r in refs if re.search(r'\d', r)]) | ||
# a heuristic: assume all version tags have a digit. The old git %d | ||
# expansion behaves like git log --decorate=short and strips out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
E501 line too long (84 > 79 characters)
tags = set([r for r in refs if re.search(r'\d', r)]) | ||
# a heuristic: assume all version tags have a digit. The old git %d | ||
# expansion behaves like git log --decorate=short and strips out the | ||
# refs/heads/ and refs/tags/ prefixes that would let us distinguish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
E501 line too long (83 > 79 characters)
# a heuristic: assume all version tags have a digit. The old git %d | ||
# expansion behaves like git log --decorate=short and strips out the | ||
# refs/heads/ and refs/tags/ prefixes that would let us distinguish | ||
# between branches and tags. By ignoring refnames without digits, we |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
E501 line too long (84 > 79 characters)
# expansion behaves like git log --decorate=short and strips out the | ||
# refs/heads/ and refs/tags/ prefixes that would let us distinguish | ||
# between branches and tags. By ignoring refnames without digits, we | ||
# filter out many common branch names like "release" and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
# refs/heads/ and refs/tags/ prefixes that would let us distinguish | ||
# between branches and tags. By ignoring refnames without digits, we | ||
# filter out many common branch names like "release" and | ||
# "stabilization", as well as "HEAD" and "master". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E117 over-indented (comment)
return set([obj for obj in parent.__dict__.values() | ||
if isinstance(obj, type_)]) | ||
return {obj for obj in parent.__dict__.values() | ||
if isinstance(obj, type_)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E127 continuation line over-indented for visual indent
"specified as non-cyclic, but Region's " | ||
"definition requires wraparound longitudes.") | ||
return data.where(self._make_mask(data, lon_str=lon_str, | ||
lat_str=lat_str)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E127 continuation line over-indented for visual indent
date_type, test_type, vert_in_label, vert_out_label)] = ( | ||
date_range, var, vert_in, vert_out) | ||
_CALC_TESTS = { | ||
'{}-{}-{}-{}'.format(date_type, test_type, vert_in_label, vert_out_label): ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (80 > 79 characters)
self.description = '' | ||
else: | ||
self.description = self.func.__doc__ | ||
self.description = '' if self.func.__doc__ is None else self.func.__doc__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (85 > 79 characters)
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run: