-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fine-grained tokens #2
Comments
I'd like to note that currently Line 33 in 98f0591
you use the
in this case, I think you can use $GITHUB_ACTOR to use the current trigger-er user as the username. That's what I think is best practice (I vaguely remember seeing that pattern used before) but I can't point to a specific "best practice because $X does it this way" on this. The alternative is GITHUB_REPOSITORY_OWNER which doesn't seem as semantically correct but idk. this could be the cause of some of the confusion in #1 ??? maybe? idk. particularily this though jumps out as a misconfig with the user/pass thing the error makes sense that "cant find password" would mean that it literally cant find the password since its in the username slot misplaced... |
ref #22 with related discussion about dummy user |
heres my (admittedly imcomplete) writeup of the github token madness: https://github.com/Andrew-Chen-Wang/github-wiki-action/blob/jcbhmr/wiki/Home.md |
Looks like the link is invalid. Could you find a permalink? |
whoops! I merged the |
Here are some notes on fine-grained token support
The text was updated successfully, but these errors were encountered: