Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Andrew-Chen-Wang/github-wiki-action #82

Closed
wants to merge 2 commits into from
Closed

Merge Andrew-Chen-Wang/github-wiki-action #82

wants to merge 2 commits into from

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented May 23, 2023

This PR would merge in my contributions from Andrew-Chen-Wang/github-wiki-action

Things have been customized (a bit) to match this repo. For instance, in the examples I've used spenserblack/actions-wiki@v1

closes #72
closes #68
closes #70
closes #49
closes #2
closes #67

related #57

@jcbhmr
Copy link
Contributor Author

jcbhmr commented May 23, 2023

Be warned! This would bring this action to feature-parity with the Andrew-Chen-Wang repo. That comes with a lot of nice features and good docs! 😊 But it also means that this repo would be essentially a fork with no changes 😢 #78

It looks like this action is being taken in a new direction with potentially more complexity? #80 😀 If so, then this is PR would merge in a great baseline to improve from.

@jcbhmr jcbhmr marked this pull request as ready for review May 23, 2023 20:16
@jcbhmr
Copy link
Contributor Author

jcbhmr commented May 23, 2023

Note that this would also change the text in the "Alternatives" section to drop the windows compat thing. That's been added in https://github.com/Andrew-Chen-Wang/github-wiki-action/releases/tag/v4.0.0

@spenserblack
Copy link
Owner

I think that, until the rewrite is complete and merged in, there should be a feature freeze. I'll consider the rewrite as v0.4.

Perhaps you can document in Andrew-Chen-Wang's action that this competitor's development has slowed for a rewrite 😜

@spenserblack spenserblack added the icebox Issues that are not a priority label May 23, 2023
@jcbhmr jcbhmr closed this Jun 9, 2023
@jcbhmr jcbhmr deleted the merge-Andrew-Chen-Wang-github-wiki-action branch June 9, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Issues that are not a priority
Projects
None yet
2 participants