-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test script #58
Comments
Screenshot is from a PR, right? IMO the solution is that this should be a dry-run for PRs, and actually push changes for pushes to |
you're right. i was misunderstanding the error message. i thought it failed to pull when (youre right) it failed to push thus something is wrong with this? - uses: ./
with:
# For now, you'll need to manually specify a GitHub token until we
# solve #2. The x: prefix is a dummy username.
token: x:${{ secrets.GITHUB_TOKEN }}
dry-run: ${{ github.ref == 'main' }} |
yeah confirmed: dry-run was FALSE for some reason: |
actually yeah that makes sense. pr has github.ref of dry-run: ${{ 'jcbhmr:some-branch' == main }}
dry-run: false when it should be: dry-run: ${{ github.ref != 'main' }}
dry-run: ${{ 'jcbhmr:some-branch' != 'main' }}
dry-run: true 🎉 |
from #57 where i wanted to see it go green
doesn't work for forks
likely problem: idk
likely solution: some fiddling with the github token perms in the settings tab?
basically the token needs READONLY perms to just the "contents: read" flag across forks which could be what's happening?
The text was updated successfully, but these errors were encountered: