Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit early if no changes #60

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Exit early if no changes #60

merged 2 commits into from
Apr 17, 2023

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Apr 13, 2023

this pr would...

  • exit early if no changes to commit
  • not push a no-op repo
  • not error when no changes

fixes #25

@jcbhmr jcbhmr marked this pull request as ready for review April 13, 2023 20:30
@jcbhmr
Copy link
Contributor Author

jcbhmr commented Apr 13, 2023

need #58 to be fixed for the test to show green
image

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Apr 13, 2023

@spenserblack ready for review

spenserblack
spenserblack reviewed Apr 17, 2023
View reviewed changes
Copy link
Owner

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I think it makes sense to add an allow-empty input, but perhaps that should be saved for a future PR.

src/index.sh Outdated Show resolved Hide resolved
@jcbhmr @spenserblack
Update src/index.sh
ccfb231 
Co-authored-by: Spenser Black <spenserblack01@gmail.com>
@spenserblack spenserblack merged commit 61322d1 into spenserblack:main Apr 17, 2023
@jcbhmr jcbhmr deleted the patch-3 branch April 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails when there's nothing to do
2 participants
@jcbhmr @spenserblack