Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add c# support #40

Merged
merged 4 commits into from
Aug 15, 2023
Merged

add c# support #40

merged 4 commits into from
Aug 15, 2023

Conversation

o2sh
Copy link
Collaborator

@o2sh o2sh commented Aug 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #40 (1d3f983) into main (c217444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files          10       10           
  Lines         365      365           
=======================================
  Hits          313      313           
  Misses         52       52           
Flag Coverage Δ
macOS-latest 85.75% <ø> (ø)
ubuntu-latest 83.23% <ø> (ø)
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

spenserblack
spenserblack previously approved these changes Aug 15, 2023
Copy link
Owner

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spelling fix 😆

Once you mispell something once, Copilot likes to mispell everywhere.

On mobile right now so I can't really check, but the # doesn't require any quoting?

Also, you want to be a collaborator?

@spenserblack
Copy link
Owner

Oh, also, do you anticipate the cs extension conflicting with anything? The heuristic is welcome, but not required if there are no reasonable conflicts.

spenserblack
spenserblack previously approved these changes Aug 15, 2023
@spenserblack spenserblack enabled auto-merge (squash) August 15, 2023 23:12
@spenserblack spenserblack disabled auto-merge August 15, 2023 23:12
@spenserblack spenserblack enabled auto-merge (squash) August 15, 2023 23:13
@spenserblack spenserblack merged commit 7e6a318 into spenserblack:main Aug 15, 2023
@spenserblack
Copy link
Owner

spenserblack commented Aug 16, 2023

Sorry, just thought of one last thing: were you able to check if the language override works with this special character? I was unsure about the gitattributes parsing, and if I needed to implement aliases.

Edit: nevermind, I just checked and gengo-language=C# does work. Thanks again for the PR!

@o2sh o2sh deleted the feat/csharp-support branch August 16, 2023 19:16
@o2sh
Copy link
Collaborator Author

o2sh commented Aug 16, 2023

Oh, also, do you anticipate the cs extension conflicting with anything? The heuristic is welcome, but not required if there are no reasonable conflicts.

Yes according to linguist, c# is associated with .cs, .csx, .linq and .cake, tokei only mentions .cs and .csx. I couldn't find any information on .linq however, so I may leave it out 🤔

@o2sh o2sh mentioned this pull request Aug 16, 2023
@spenserblack
Copy link
Owner

Oh, browsing through linguist, I see that Smalltalk uses the .cs extension, too. So, yeah, the heuristic definitely helps future-proof 🙂

@spenserblack
Copy link
Owner

spenserblack commented Aug 16, 2023

BTW, about .linq: github-linguist/linguist@8866bb0

I think we can leave it out for now -- skimming the PR, it might be considered a slightly different language since it has metadata? 🤷 I'm fine with not adding it until somebody asks for it.

@spenserblack
Copy link
Owner

@all-contributors add @o2sh for data

@allcontributors
Copy link
Contributor

@spenserblack

I've put up a pull request to add @o2sh! 🎉

@spenserblack spenserblack added the new-language Requests to add a new language label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-language Requests to add a new language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants