Fix NerdFont glyphs #435
Merged
Fix NerdFont glyphs #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the 16-bit escapes with 32-bit escapes for NerdFont glyphs. This fixes some of the entries, which previously had invalid 16-bit escape strings. It seems that the 32-bit hex codes were entered, so a simple find-and-replace seems to have fixed the entries.
spenserblack
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 18 18
Lines 502 502
=======================================
Hits 370 370
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid 16-bit Unicode escapes were used in the data file. These escapes were all actually 32-bit Unicode escapes with the leading 0s truncated. Converting them to 32-bit escapes (
\U) with leading zeroes fixed the code points.