Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 2.7 #266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Deprecate 2.7 #266

wants to merge 1 commit into from

Conversation

spenserblack
Copy link
Owner

@spenserblack spenserblack commented Jan 10, 2023 •
edited
Loading

Resolves #264

To do checklist

  • Update/create RELEASE_NOTES file if necessary

Note

With some popular distros still using 2.7, this probably won't get merged for a long time.

@spenserblack spenserblack linked an issue Jan 10, 2023 that may be closed by this pull request
Bump minimum supported Ruby version #264
Open
3 tasks
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #266 (1749d7e) into main (f3e5713) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1749d7e differs from pull request most recent head 8fe19b9. Consider uploading reports for the commit 8fe19b9 to get more accurate results

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          18       18           
  Lines         749      749           
=======================================
  Hits          657      657           
  Misses         92       92
Flag Coverage Δ
macos-latest 87.29% <100.00%> (ø)
ruby-2.7 ?
ruby-3.0 87.29% <100.00%> (ø)
ruby-3.1 87.71% <100.00%> (ø)
ruby-3.2 87.71% <100.00%> (?)
ubuntu-latest 87.29% <100.00%> (ø)
windows-latest 87.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/repofetch/github.rb 51.25% <100.00%> (ø)
lib/repofetch/gitlab.rb 51.38% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spenserblack spenserblack added the help wanted Extra attention is needed label Jan 10, 2023
@spenserblack spenserblack force-pushed the 264/deprecate-2.7 branch 2 times, most recently from 41fcf97 to 583567e Compare January 12, 2023 18:24
@spenserblack
Bump minimum Ruby version to 3.0
8fe19b9 
This bumps the Ruby version in the devcontainer, removes 2.7 from the
CI, and updates the gemspec.

This also fixes a style issue that was detected in version 3.0.
@spenserblack spenserblack force-pushed the 264/deprecate-2.7 branch 2 times, most recently from 1749d7e to 8fe19b9 Compare January 12, 2023 18:30
@spenserblack spenserblack removed the help wanted Extra attention is needed label Jan 13, 2023
@spenserblack spenserblack changed the title Update Ruby version Deprecate 2.7 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump minimum supported Ruby version
1 participant
@spenserblack