Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3171
This is essentially "stolen" from pyinstaller/pyinstaller#1566 (comment)
With this, binaries should work on Windows 10 by default (as with 3.0.0).
On Windows 7 and 8.1, binaries might work by default; if they don't work, the end-user should
Either of these two things should fix it. To clarify, the end-user has to install one of these.
Hence I would call this a "hotfix".
I've tested on Windows 10 and 7; and skace (from #electrum) tested on 8.1 - thanks for that.
No idea about earlier Windows versions.
These are the DLLs we are removing (in my dev environment):
The
MSVCR100.dll
seems to be redundant. The'api-ms-win-crt-*
DLLs are stubs from Wine, which don't actually work on Windows. I think 3.0.0 only works on Windows 10 as it somehow successfully fallbacks to the real DLLs which are part of Win10 by default. The above linked Win update or the VC++ redist both make sure that these are available on the older Windows versions.