Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OnionFailureCode returned when failing trampoline forwarding #9433

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

f321x
Copy link
Member

@f321x f321x commented Jan 15, 2025

This changes the OnionFailureCode returned from maybe_forward_trampoline() on PaymentFailure to TRAMPOLINE_FEE_INSUFFICIENT so the client will retry the payment with higher trampoline fee instead of giving up.

@ecdsa
Copy link
Member

ecdsa commented Jan 15, 2025

Note: This reverts eda9097. That commit is related to a discussion in lightning/bolts#829

The FIXME indicates that there are some cases where it would make sense to return unknown_next_peer.
Specifically:

@ecdsa ecdsa merged commit 2ac17d0 into spesmilo:master Jan 15, 2025
10 of 13 checks passed
@f321x f321x deleted the change_onion_message branch January 15, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants