add orjson #53
Open
add orjson #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any benchmarks comparing orjson to the other options? Should it really be the preferred option in cases where more than 1 are present? |
|
I have no issue with us supporting orjson as well, will run some benchmarks against typical Bitcoin block serialization. I've restarted the tests for this PR now that they're working again. |
JustinTArthur
requested changes
Oct 12, 2020
| except ImportError: | ||
| import json | ||
|
|
||
| print("using", json.__name__) |
There was a problem hiding this comment.
Can you remove this print statement for now? It should eventually be a logger.debug from one of the modules responsible for environment on startup.
|
Could the json-related note in https://github.com/spesmilo/electrumx/blob/master/docs/PERFORMANCE-NOTES also get updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.