Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to vendor our dependencies? #72

Closed
mbertschler opened this issue Feb 19, 2016 · 3 comments
Closed

How to vendor our dependencies? #72

mbertschler opened this issue Feb 19, 2016 · 3 comments
Labels
Milestone

Comments

@mbertschler
Copy link
Collaborator

@spf13 What process should we use to vendor our dependencies?

Now that Go 1.6 is released and vendoring is enabled by default we should use something that uses the /vendor subdirectory approach. Should we use a tool for that or just make a subtree merge with squashed commits?

The reason why we should vendor is for example this issue: #59

@mbertschler mbertschler added this to the afero v0.11 milestone Feb 19, 2016
@xor-gate
Copy link
Contributor

This option is also available for Go 1.5 when enable manually. I don't know which version we should support as minimal ? I tried myself on Go 1.6 and it seems to work perfectly without the need for external tools.

@victpork
Copy link

Hi when trying to pass the PR #154 found out that CI could not compile for Go 1.7.5, and found that the guys at sftp package already dropped support for versions below 1.8. We should start using dependency management tool ASAP. I suggest we should use dep and check in the vendor directory.

@0xmichalis
Copy link
Collaborator

go modules are used now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants