Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sftp_test has errors #59

Closed
spf13 opened this issue Jan 11, 2016 · 3 comments
Closed

Sftp_test has errors #59

spf13 opened this issue Jan 11, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@spf13
Copy link
Owner

spf13 commented Jan 11, 2016

./sftp_test.go:203: cannot use debugStream (type io.Writer) as type string in argument to sftp.NewServer
./sftp_test.go:203: cannot use debugLevel (type int) as type sftp.ServerOption in argument to sftp.NewServer
./sftp_test.go:203: cannot use readOnly (type bool) as type sftp.ServerOption in argument to sftp.NewServer
./sftp_test.go:203: cannot use rootpath (type string) as type sftp.ServerOption in argument to sftp.NewServer

I'm not sure if it's just me, but this doesn't look like it should have ever built. If I'm doing something wrong, please let me know.

@xor-gate
Copy link
Contributor

It did work, those guys started to break the master branch exactly 6 days ago:

pkg/sftp@8a7343c

https://github.com/pkg/sftp/commits/master

screen shot 2016-01-17 at 22 24 59

Maybe we should blame them 👍

Probably we should upgrade to the new sftp.ServerOption and then we are good to go.

In the (near) future the whole sftp package will be refactored: pkg/sftp#84

@spf13
Copy link
Owner Author

spf13 commented Jan 17, 2016

Doh. We need to vendor these deps.
On Sun, Jan 17, 2016 at 4:25 PM Jerry Jacobs notifications@github.com
wrote:

It did work, those guys started to break the master branch exactly 6 days
ago:

https://github.com/pkg/sftp/commits/master

[image: screen shot 2016-01-17 at 22 24 59]
https://cloud.githubusercontent.com/assets/1050166/12380059/417b56c0-bd69-11e5-9d9a-c6c3dc746536.png


Reply to this email directly or view it on GitHub
#59 (comment).

@0xmichalis
Copy link
Collaborator

Fixed by #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants