mem/file.go - Fix some races in accessing fields of FileData #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bep
requested changes
Aug 25, 2017
mem/file.go
Outdated
| f.name = newname | ||
| } | ||
|
|
||
| func SetMode(f *FileData, mode os.FileMode) { | ||
| f.Lock() | ||
| defer f.Unlock() |
There was a problem hiding this comment.
No need to use defer when the method is so short.
There was a problem hiding this comment.
Also, it would be great if you added a test that demonstrates this problem.
|
@bep thanks for the review and sorry for the delay addressing them. I also enabled Now I realize I should maybe have added it in the main |
* Splitting SetModeTime to avoid double locking * Adding locks all over the place.
|
I verified that the new tests fail with data races without this patch. |
|
Fixes #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #133