Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SftpFs beta backend #48

Merged
merged 6 commits into from
Jan 7, 2016
Merged

Add SftpFs beta backend #48

merged 6 commits into from
Jan 7, 2016

Conversation

xor-gate
Copy link
Contributor

As discussed in #47, have fun :-)

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@xor-gate
Copy link
Contributor Author

It seems continues integration chokes on the test, i have no real clue how to make this actually work. The problem is we need to spawn a sftp server and test against it. Or remove the "example/test" completely.

@xor-gate
Copy link
Contributor Author

xor-gate commented Jan 2, 2016

@mbertschler you are right I fixed up the test and now spawn a Sftp server and generate the RSA host key 👍. Still the implementation and the test needs some love and polishing but it is nice to have a stub sftp server and don't rely on a hosted sftp server.

@mbertschler
Copy link
Collaborator

@xor-gate the Sftp server in the tests is a good idea 👍.
I have not tested it yet but I think this is ready to merge as an experimental feature. I will probably play around with it in the next days, and also see if this FS works with our existing tests.

mbertschler added a commit that referenced this pull request Jan 7, 2016
@mbertschler mbertschler merged commit c2313a7 into spf13:master Jan 7, 2016
@xor-gate
Copy link
Contributor Author

xor-gate commented Jan 7, 2016

Thank you @mbertschler. And yes having the sftp server stub in the test makes sure with the CI tests that everything is still functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants