Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes spf13/afero#79 #80

Merged
merged 3 commits into from
Apr 18, 2016
Merged

Closes spf13/afero#79 #80

merged 3 commits into from
Apr 18, 2016

Conversation

francoishill
Copy link
Contributor

Added fix to support "nested" BasePathFs. Unit-tests are also included.

@francoishill
Closes #79
9a1fcfb 
Added fix to support "nested" `BasePathFs`. Unit-tests are also included.
@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@francoishill francoishill mentioned this pull request Apr 18, 2016
Closed
@francoishill
Closes #79
139c771 
Rather keep the `RealPath` behaviour as originally implemented. Added a new method `fullPath` which is used by all other methods like `MkDir`.
@francoishill
Closes #79
8e75131 
Amendment to previous commit, fixed the related test
@mbertschler
Copy link
Collaborator

Thanks for the quick PR!

@mbertschler mbertschler merged commit a80ea58 into spf13:master Apr 18, 2016
@francoishill
Copy link
Contributor Author

Hi @mbertschler

Please accept my pull request 82, I reverted the previous fullPath changes because although this fixes a specific scenario, it breaks some other ones.

I did however add tests for testing MkDirAll for the "nested" BasePath scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francoishill @CLAassistant @mbertschler