API (urgent): Rename BashCompDirectives to ShellCompDirectives #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the completion directives will be used for all shells, and that these names will be consumed by users, this is a more appropriate name. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
jharshman
added
kind/feature
|
Thank you @jharshman ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
BashCompDirectivestoShellCompDirectivesWhen answering questions in #1070 about Zsh completion, I realized that the naming for the Completion Directives could be improved. Since those completion directives will be used for different shells, and that these names will be consumed by users, it is more appropriate not to include
bashin the name.If this is worth doing, it should be done right away before the old names get locked as a released API. Assuming it is still ok to make this change.
@jharshman what do you think?