Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env variable available for git outh key #1089

Closed
wants to merge 1 commit into from

Conversation

Salamandastron1
Copy link

@Salamandastron1 Salamandastron1 commented Apr 12, 2020

Hey!

Auto deploy configuration for Travis complete 🖖

There will be a little bit of setup necessary in to use a github oauth token. I'll link the docs below. The setup should all be here though. It will only deploy automagically on tags, which seem to be deliberately used in the repo so it should be muy bien.

https://docs.travis-ci.com/user/deployment/releases/#authenticating-with-an-oauth-token

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2020

CLA assistant check
All committers have signed the CLA.

@umarcor
Copy link
Contributor

umarcor commented Apr 13, 2020

I suggest using GitHub Actions instead, since the default GITHUB_TOKEN does already allow to upload artifacts and/or creating releases.

Ref #952 #968

@Salamandastron1
Copy link
Author

Travis suggests making a machine user for this to work, and generating api key for via the information in the docs I linked. All for either implementation of Travis or Github actions but I was asked to keep this in scope of the current CI/CD method.

@umarcor
Copy link
Contributor

umarcor commented Apr 13, 2020

Travis suggests making a machine user for this to work, and generating api key for via the information in the docs I linked. All for either implementation of Travis or Github actions but I was asked to keep this in scope of the current CI/CD method.

Yes, Travis requires explicitly generating an API key/token, and because of limited configurability of scopes, it is suggested to create a machine user. AFAIK, doing so requires to create an e-mail account for the machine user. Conversely, the GITHUB_TOKEN available in GHA by default does already have a limited scope (see https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token), so creation of a machine user or a custom token is not required. Anyway, if you are constrained to use Travis, there is little you can do...

@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants