Extend Persistent*Run behavior to allow multiple hooks throughout the execution chain #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively I've created a package Cobrahooks that attempts to introduce the functionality from this PR as close as possible. |
|
This PR is being marked as stale due to a long period of inactivity |
hoshsadiq
pushed a commit
to zulucmd/zulu
that referenced
this pull request
Dec 31, 2022
Supersedes: PR #1123 Resolves: #252, #219 Related PR's: #714, #220 - Introduces On*Run() methods to register hooks - Introduces OnPersistent*Run() methods to register hooks that are always executed (childs not overriding parents). - Allows to register multiple *Run hooks - Keeps current Persistent*Run behavior unaffected (childs still override parents when set as a property) - Introduces EnablePersistentRunOverride option to control if child Persistent*Run hooks should override their parent's hooks Merge spf13/cobra#1142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: PR #1123
Resolves: #252, #219
Related PR's: #714, #220