-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shell_completions.md to have automatically rootcmd #1372
Update shell_completions.md to have automatically rootcmd #1372
Conversation
PS - it seems the MING64 fails because of a to bypass this you can |
seems this fail was solved by #1366 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good suggestion @georgettica, thanks! Just a couple of updates needed.
@marckhouzam fixed as you suggested, glad I could contribute :) |
seems the MING64 issue is regarding #1348 and the comment I made there |
This PR is being marked as stale due to a long period of inactivity |
Can this be assisted with? |
/retest |
@marckhouzam how do I retest? And is this issue solved in upstream that a rebase will work? |
@georgettica you can rebase on master and do a force-push |
4e20211
to
b0d065a
Compare
@marckhouzam done, need approval to run workflows |
@marckhouzam can you remove the stale flag? Hopefully this can be merged now |
I'm not a maintainer, I just help out as best I can. I expect this will be merged when we are closer to the next release. |
From looking around @jpmcb has doneaa merge before.. maybe he can help? And thanks for your help @marckhouzam |
@jpmc maybe you can TAL ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks much for the patience here! ❤️
tested and it works! found an issue I will file / check if it's not noted |
this makes using this snippet easier