dep init #523
Closed
dep init #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zevdg
commented
Aug 30, 2017
Gopkg.lock
Outdated
| name = "github.com/cpuguy83/go-md2man" | ||
| packages = ["md2man"] | ||
| revision = "a65d4d2de4d5f7c74868dfa9b202a3c8be315aaa" | ||
| version = "v1.0.6" |
There was a problem hiding this comment.
This particular version is actually wrong and problematic. It pulls in blackfriday v2 and breaks stuff. Do not approve this PR until this dependency has been updated.
Also adds go 1.9 and some small improvements inspired by the docs at https://docs.travis-ci.com/user/languages/go
zevdg
commented
Aug 30, 2017
|
|
||
| before_install: | ||
| - mkdir -p bin | ||
| - curl -Lso bin/shellcheck https://github.com/caarlos0/shellcheck-docker/releases/download/v0.4.3/shellcheck | ||
| - chmod +x bin/shellcheck | ||
| script: | ||
| - PATH=$PATH:$PWD/bin go test -v ./... |
There was a problem hiding this comment.
fyi, this line ignores the vendor folder as expected in go1.9, but not in previous versions of go. The changes I've made work across all go versions.
|
AFAICT, this is safe to merge now. Now it's just up to you all to decide if you're ready to adopt The .travis.yml fixes are probably a good idea even if you aren't ready to adopt dep yet. |
|
Agreed on both counts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not just a normal
dep init. This is 1dep initin the project root without the vendor folder and then anotherdep initin the cobra subdirectory with the vendor folder. This gives you reproducible builds on the tool without causing problems for clients of the library solving both problems outlined in #259I don't necessarily expect this to get merged as is. It could be, but I initially created it just to further the dialog by showing an example of that this could look like.