Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile to project #976

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

jharshman
Copy link
Collaborator

@jharshman jharshman commented Oct 7, 2019

Add Makefile(s) to project. Tweak TravisCI to use the makefile targets. Remove Circle CI as it currently only duplicates work.

  • Developers test and build using the same commands the CI system will execute.
  • Leverage github.com/mitchellh/gox to cross compile for different architectures.
  • Generator builds drop into ./bin directory.

Resolves:
#936
#876

@jharshman jharshman added the kind/feature A feature request for cobra; new or enhanced behavior label Oct 7, 2019
@jharshman jharshman added this to the 1.0.0 milestone Oct 7, 2019
Copy link
Contributor

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about what are you trying to define in Travis. Four jobs are being inferred from the go matrix. An additional job is added to execute make fmt only with go version 1.12.x only. And a last job is added to run make test only with a single go version.

I think that make test can be added in the diff stage. Furthermore, I'd just remove the jobs: include and run make all on four jobs.

.travis.yml Outdated Show resolved Hide resolved
cobra/Makefile Show resolved Hide resolved
@umarcor
Copy link
Contributor

umarcor commented Oct 8, 2019

@jharshman, how about adding 1.13.x?

@jharshman
Copy link
Collaborator Author

@umarcor Well right now it's testing tip which I assume is the latest and greatest version of Go.
Currently I' considering the following -

  • Removing Circle CI as it seems repetitive.
  • To what degree do we care about running tests against older versions of Go? i.e: 1.13.x is out, do we care about testing 1.10.x?

@umarcor
Copy link
Contributor

umarcor commented Oct 9, 2019

@umarcor Well right now it's testing tip which I assume is the latest and greatest version of Go.

1.13.x was released last month: https://blog.golang.org/go1.13. tip is currently 1.14.x.

  • Removing Circle CI as it seems repetitive.

Agree. Precisely, I would remove Travis too, and go with GitHub Actions. I can merge this with #968.

  • To what degree do we care about running tests against older versions of Go? i.e: 1.13.x is out, do we care about testing 1.10.x?

Officially, the two latest versions are supported: https://golang.org/doc/devel/release.html#policy. Hence, neither 1.10.x nor 1.11.x are supported. Precisely, that's the motivation not to care about deprecating both of them in #876. Should you decide to remove them, please consider adding #876 to 1.0.0.

@jharshman jharshman changed the title WIP: Add Makefile to project Add Makefile to project Dec 26, 2019
@jharshman jharshman force-pushed the makefile-driven branch 2 times, most recently from df71485 to feabcee Compare December 26, 2019 18:54
@jharshman jharshman requested review from spf13 and eparis December 26, 2019 19:06
@jharshman jharshman self-assigned this Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants