-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile to project #976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about what are you trying to define in Travis. Four jobs are being inferred from the go
matrix. An additional job is added to execute make fmt
only with go version 1.12.x
only. And a last job is added to run make test
only with a single go version.
I think that make test
can be added in the diff
stage. Furthermore, I'd just remove the jobs: include
and run make all
on four jobs.
@jharshman, how about adding |
@umarcor Well right now it's testing tip which I assume is the latest and greatest version of Go.
|
Agree. Precisely, I would remove Travis too, and go with GitHub Actions. I can merge this with #968.
Officially, the two latest versions are supported: https://golang.org/doc/devel/release.html#policy. Hence, neither |
df71485
to
feabcee
Compare
remove circle ci
feabcee
to
ea02be9
Compare
Add Makefile(s) to project. Tweak TravisCI to use the makefile targets. Remove Circle CI as it currently only duplicates work.
Resolves:
#936
#876