allow for blank ip addresses #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
therealmitchconnors
approved these changes
Jun 4, 2021
djdv
pushed a commit
to djdv/pflag
that referenced
this pull request
Jul 5, 2022
algitbot
pushed a commit
to alpinelinux/build-server-status
that referenced
this pull request
Jan 30, 2025
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/pflag](https://github.com/spf13/pflag) | require | patch | `v1.0.5` -> `v1.0.6` | --- ### Release Notes <details> <summary>spf13/pflag (github.com/spf13/pflag)</summary> ### [`v1.0.6`](https://github.com/spf13/pflag/releases/tag/v1.0.6) [Compare Source](spf13/pflag@v1.0.5...v1.0.6) #### What's Changed - Add exported functions to preserve `pkg/flag` compatibility by [@​mckern](https://github.com/mckern) in spf13/pflag#220 - remove dead code for checking error nil by [@​yashbhutwala](https://github.com/yashbhutwala) in spf13/pflag#282 - Add IPNetSlice and unit tests by [@​rpothier](https://github.com/rpothier) in spf13/pflag#170 - allow for blank ip addresses by [@​duhruh](https://github.com/duhruh) in spf13/pflag#316 - add github actions by [@​sagikazarmark](https://github.com/sagikazarmark) in spf13/pflag#419 #### New Contributors - [@​mckern](https://github.com/mckern) made their first contribution in spf13/pflag#220 - [@​yashbhutwala](https://github.com/yashbhutwala) made their first contribution in spf13/pflag#282 - [@​rpothier](https://github.com/rpothier) made their first contribution in spf13/pflag#170 - [@​duhruh](https://github.com/duhruh) made their first contribution in spf13/pflag#316 - [@​sagikazarmark](https://github.com/sagikazarmark) made their first contribution in spf13/pflag#419 **Full Changelog**: spf13/pflag@v1.0.5...v1.0.6 </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> See merge request alpine/infra/build-server-status!19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in some CI systems they'll often do things like
--ip=$SOME_IPin the case that$SOME_IPis blank or a blank string it would be helpful if we didn't fail out right away and allow for defaulting, this is somewhat similar to #84 and related to kubernetes/kubernetes#58686