Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #1204

Closed
wants to merge 0 commits into from
Closed

upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #1204

wants to merge 0 commits into from

Conversation

inteon
Copy link

@inteon inteon commented Sep 3, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark
Copy link
Collaborator

Looks like upgrading breaks some of the tests.

@inteon
Copy link
Author

inteon commented Sep 16, 2021

@sagikazarmark the failing tests were due to indentation issues.
I updated the behavior to match the old indentation as close as possible & changed the indentation in the remaining tests.

@Degretor
Copy link

Degretor commented Oct 12, 2021

Hi guys,
any update on this PR? We need to have some features from yaml v3 in our project and would appreciate if this would go in.
Thanks!

@fikurillo
Copy link

Hi Inteon,

Could you tell me, what is the plan with this issue? It would be helpfull for me, if it would be mereged.

Thanks in advance for any news.

@inteon
Copy link
Author

inteon commented Oct 13, 2021

Hey @fikurillo, I think this PR is ready to get merged. I'm waiting for a review.

Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase from master?

internal/encoding/yaml/codec.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants