-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SaveConfig(). #153
Adding SaveConfig(). #153
Conversation
} | ||
|
||
f, err := os.Create(v.getConfigFile()) | ||
defer f.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer should after check error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it. Thanks for pointing it out!
…r checking must be first otherwise it will cause panic.
LGTM 👍 . Just needs docs. EDIT: Would also close #33 . |
Thanks for the contribution! A few suggestions:
I think you've done most of the work already, it's just mostly a question of reorganizing things. Let me know if you want help or have questions. Happy to help. |
This idea is six months old, so I'd assume this PR is dead? |
@g3rk6 hi, anything (other than time) blocking you from progressing in this front ? |
Sorry for the long delay. At the moment the only issue is time and currently super busy. I'll try to make some progress as soon as I get some time. Thanks. |
@g3rk6 I'd love to see this fully implemented. I think it is looking good. A group I am part of may have some time to dedicate to helping with it here shortly. |
this is stale and it appears #287 has carried it forward. Closing this. |
It would be nice to have a way to store configuration into a file. There could be better way of doing it, but this is the version that works for me.