Fixed AllKeys() to include env values added with BindEnv() #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitmasson
changed the title
AllKeys() to include env values added with BindEnv()
To make sure AllSettings() and Unmarshal() will consider environment variables added with BindEnv().
Cast was not working, and v.env wasn't used when merging keys. Rewrote explicit and specific casts for maps storing strings or FlagValues.
benoitmasson
force-pushed
the
unmarshal-bindenv
branch
from
1c82291 to
dfa6f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixed in
AllKeys()by doing an explicit cast ofv.envto amap[string]interface{}.This will in turn repair
AllSettings()andUnmarshal(), which also ignored environment values added manually.Fixes issue raised in this comment in PR #195, and mentioned at the end of Issue #188.