Checked algebraic laws, refactoring #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphaso
commented
Oct 15, 2023
| @@ -60,8 +60,7 @@ defmodule Noether.Either do | |||
| {:error, "Value not found"} | |||
| """ | |||
| @spec join(either()) :: either() | |||
| def join({:ok, {:ok, a}}), do: {:ok, a} | |||
| def join({:ok, {:error, a}}), do: {:error, a} | |||
| def join(a = {_, {_, _}}), do: bind(a, & &1) | |||
There was a problem hiding this comment.
In Haskell, join from Control.Monad is implemented in terms of bind.
sphaso
commented
Oct 15, 2023
| @@ -9,10 +9,10 @@ defmodule Noether.Maybe do | |||
|
|
|||
| ## Examples | |||
|
|
|||
| iex> map(nil, &Kernel.abs/1) | |||
| iex> Noether.Maybe.map(nil, &Kernel.abs/1) | |||
There was a problem hiding this comment.
The library that we use for Property Testing has a function called map, therefore I need to break the ambiguity.
sphaso
commented
Oct 15, 2023
| @@ -35,9 +35,9 @@ defmodule Noether.MixProject do | |||
| # Run "mix help deps" to learn about dependencies. | |||
| defp deps do | |||
| [ | |||
| {:credo, "~> 1.6.4", only: :dev, runtime: false}, | |||
| {:credo, "~> 1.7", only: :dev, runtime: false}, | |||
sphaso
force-pushed
the
added_tests_refactoring
branch
2 times, most recently
from
ff37bcf to
d5d9c36
Compare
sphaso
force-pushed
the
added_tests_refactoring
branch
from
d5d9c36 to
a5af09e
Compare
neslinesli93
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a conversation with Tom, I wanted to check that Noether respects basic Functor and Monadic laws. The good news is that it does, the bad news is that
Either.bindshould ideally be more strict.For now I decided to go with a warning in the docs instead of a proper error.
After writing the tests, I decided to increase the inter-function dependency in
Maybe. I doubt this will cause any issue in existing codebases, therefore I only consider this a "refactoring change" in the semver.