This repository has been archived by the owner on Dec 20, 2019. It is now read-only.
Better named colour check - Fixes #24 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'black' was coming back falsey and coming back as invalid
|
Thanks for the PR. Seems like a reasonable check, merging. |
deadprogram
added a commit
that referenced
this pull request
Jan 9, 2016
Better named colour check - Fixes #24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
'black' was coming back falsey and being read as invalid.
Now this checks for the property rather than the value being truthy.
I'm not familiar with Mocha but maybe we could loop through the colour list and check they all work in the tests?