update packaging and testing and drop EoL Pythons #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
update-packaging-and-testing-and-drop-eol-pythons
branch
from
9d5825b
to
fb7efd5
Compare
terencehonles
force-pushed
the
update-packaging-and-testing-and-drop-eol-pythons
branch
from
fb7efd5
to
60a396b
Compare
terencehonles
commented
Nov 2, 2024
terencehonles
commented
Nov 2, 2024
There was a problem hiding this comment.
I left this as its own file, but it can be moved to pyproject.toml too, but we'd need to ensure tox v4 I believe and probably will need to use a different Github Actions runner
terencehonles
commented
Nov 2, 2024
| wheel | ||
| # last release for old versions | ||
| sphinx747: sphinx==7.4.7 | ||
| sphinx621: sphinx==6.2.1 |
There was a problem hiding this comment.
I dropped 5.x because it looks like it has issues with Python 3.13 since it imports the removed imghdr module differently than more recent versions, and I don't know if we need to go that far back. Otherwise we can just change the envlist to not include 5x for Python 3.13, but two older releases seem sufficient.
terencehonles
commented
Nov 2, 2024
| [testenv:wheel] | ||
| minversion = 3.15.0 | ||
| commands = | ||
| python -m build --wheel . |
There was a problem hiding this comment.
Since building the wheel doesn't need to be tested in all the Python versions I split this out, and only test that it builds with the latest Python (at least on the CI), if you run locally I believe this will use the base Python.
terencehonles
commented
Nov 2, 2024
| commands = | ||
| ./setup.py bdist_wheel | ||
| ./setup.py install |
There was a problem hiding this comment.
tox always installs the package (unless you say otherwise), so this was redundant
terencehonles
commented
Nov 2, 2024
sphinxcontrib/__init__.py
Outdated
There was a problem hiding this comment.
pyproject.toml handles namespace packages automatically
terencehonles
commented
Nov 2, 2024
setup.cfg
Outdated
There was a problem hiding this comment.
Universal wheels are deprecated and are only needed for Python 2, so since we're dropping Python 2 this isn't needed.
terencehonles
commented
Nov 2, 2024
| author_email='tomasz.czyz@gmail.com', | ||
| description='Sphinx extension for thumbnails', | ||
| long_description=codecs.open('README.rst', encoding="utf8").read(), | ||
| zip_safe=False, |
There was a problem hiding this comment.
This looks like it's deprecated and doesn't seem to apply to Python 3 (or it can still break since you can install zip packages, but that's not standard)
terencehonles
commented
Nov 2, 2024
pyproject.toml
Outdated
| ] | ||
| dependencies = [ | ||
| "requests>2.2,<3", | ||
| "setuptools", # TODO: migrate off of pkg_resources |
There was a problem hiding this comment.
This is now properly declared as a dependency until pkg_resources is not used here:
images/sphinxcontrib/images.py
Lines 285 to 288 in 30b50b8
It's no longer needed for namespace packages
This was referenced Nov 2, 2024
Open
terencehonles
force-pushed
the
update-packaging-and-testing-and-drop-eol-pythons
branch
2 times, most recently
from
b771f06
to
8d4045c
Compare
terencehonles
force-pushed
the
update-packaging-and-testing-and-drop-eol-pythons
branch
from
8d4045c
to
83283c7
Compare
|
I've verified that the packaging creates the same assets (aside from the previously missing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles a few points on #40, but will have a failing test without #39
fixes: #36 , fixes: #37